Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hl] Revert use hl.NativeArray for Vector #11568 #11766

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

yuxiaomao
Copy link
Contributor

Revert #11568
But keeps some tests

@Simn
Copy link
Member

Simn commented Sep 11, 2024

If we revert this we might also consider reverting #11734 because #11568 was the only reason I added that. That's not my call to make though.

@yuxiaomao
Copy link
Contributor Author

I have think of it. But we can have Int64 ArrayBytes, which might still be interesting; and add a type to TArray is not a bad things by it self.
@ncannasse any advise?

@Simn Simn merged commit 7f3dd53 into development Sep 11, 2024
99 checks passed
@yuxiaomao yuxiaomao deleted the revert-11568-hl_vector_over_native_array branch September 11, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants